Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CSL-3114] Update docs to reflect new 10k limit #189

Merged
merged 3 commits into from
Mar 11, 2024
Merged

[CSL-3114] Update docs to reflect new 10k limit #189

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
028bb79
Update docs to reflect new 10k limit
Mudaafi Feb 28, 2024
b9ae221
Revert docs to itemGroups limit
Mudaafi Mar 4, 2024
50ae7ce
Lint
Mudaafi Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/modules/catalog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ class Catalog {
}

/**
* Adds multiple items to your index whilst replacing existing ones (limit of 1,000)
* Adds multiple items to your index whilst replacing existing ones (limit of 10,000)
*
* @function createOrReplaceItems
* @param {object} parameters - Additional parameters for item details
Expand Down Expand Up @@ -260,7 +260,7 @@ class Catalog {
}

/**
* Update multiple items to index (limit of 1,000)
* Update multiple items to index (limit of 10,000)
*
* @function updateItems
* @param {object} parameters - Additional parameters for item details
Expand Down Expand Up @@ -352,7 +352,7 @@ class Catalog {
}

/**
* Remove multiple items from your index (limit of 1,000)
* Remove multiple items from your index (limit of 10,000)
*
* @function deleteItems
* @param {object} parameters - Additional parameters for item details
Expand Down Expand Up @@ -501,7 +501,7 @@ class Catalog {
}

/**
* Adds multiple variations to your index whilst replacing existing ones (limit of 1,000)
* Adds multiple variations to your index whilst replacing existing ones (limit of 10,000)
*
* @function createOrReplaceVariations
* @param {object} parameters - Additional parameters for variation details
Expand Down Expand Up @@ -584,7 +584,7 @@ class Catalog {
}

/**
* Update multiple variations to index (limit of 1,000)
* Update multiple variations to index (limit of 10,000)
*
* @function updateVariations
* @param {object} parameters - Additional parameters for variation details
Expand Down Expand Up @@ -677,7 +677,7 @@ class Catalog {
}

/**
* Remove multiple variations from your index (limit of 1,000)
* Remove multiple variations from your index (limit of 10,000)
*
* @function deleteVariations
* @param {object} parameters - Additional parameters for variation details
Expand Down Expand Up @@ -886,7 +886,7 @@ class Catalog {
}

/**
* Add item groups to index (limit of 1,000)
* Add item groups to index (limit of 10,000)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mudaafi Were you able to verify with backend that this 10k change was also applied to groups endpoint? I am asking because Items and Variations are on V2 and Groups are in V1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a good point, let me ask them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting this to 1k items following backend's lead: https://constructor.slack.com/archives/CA44G41HA/p1709562698499959?thread_ts=1709314392.618379&cid=CA44G41HA

*
* @function addItemGroups
* @param {object} parameters - Additional parameters for item group details
Expand Down Expand Up @@ -1036,7 +1036,7 @@ class Catalog {
}

/**
* Add multiple item groups to index whilst updating existing ones (limit of 1,000)
* Add multiple item groups to index whilst updating existing ones (limit of 10,000)
*
* @function addOrUpdateItemGroups
* @param {object} parameters - Additional parameters for item group details
Expand Down Expand Up @@ -1119,6 +1119,7 @@ class Catalog {
* },
* });
*/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space here

modifyItemGroup(parameters = {}, networkParameters = {}) {
let requestUrl;
const { fetch } = this.options;
Expand Down
Loading