Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSL-3114] Update docs to reflect new 10k limit #189

Merged

Conversation

Mudaafi
Copy link
Contributor

@Mudaafi Mudaafi commented Feb 28, 2024

Updates the documentation to reflect the new 10k item limit when

  • Uploading Items via the Items API
  • Uploading Variations via the Variations API
  • Uploading Item Groups via the Item Groups API

I didn't regenerate the docs just yet. Will do so before I merge.

@Mudaafi Mudaafi requested a review from a team February 28, 2024 02:01
@@ -1119,6 +1119,7 @@ class Catalog {
* },
* });
*/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space here

Copy link
Contributor

@mocca102 mocca102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -886,7 +886,7 @@ class Catalog {
}

/**
* Add item groups to index (limit of 1,000)
* Add item groups to index (limit of 10,000)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mudaafi Were you able to verify with backend that this 10k change was also applied to groups endpoint? I am asking because Items and Variations are on V2 and Groups are in V1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a good point, let me ask them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mudaafi Mudaafi requested a review from esezen March 4, 2024 17:15
Copy link
Contributor

@esezen esezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@esezen esezen merged commit de47209 into master Mar 11, 2024
8 checks passed
@esezen esezen deleted the csl-3114-node-sdk-docs-update-item-limits-for-items-api-to-10k branch March 11, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants