[CSL-3114] Update docs to reflect new 10k limit #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mocca102
reviewed
Feb 28, 2024
src/modules/catalog.js
Outdated
| @@ -1119,6 +1119,7 @@ class Catalog { | |||
| * }, | |||
| * }); | |||
| */ | |||
|
|
|||
esezen
reviewed
Feb 29, 2024
src/modules/catalog.js
Outdated
| @@ -886,7 +886,7 @@ class Catalog { | |||
| } | |||
|
|
|||
| /** | |||
| * Add item groups to index (limit of 1,000) | |||
| * Add item groups to index (limit of 10,000) | |||
There was a problem hiding this comment.
@Mudaafi Were you able to verify with backend that this 10k change was also applied to groups endpoint? I am asking because Items and Variations are on V2 and Groups are in V1.
There was a problem hiding this comment.
that's a good point, let me ask them
There was a problem hiding this comment.
Reverting this to 1k items following backend's lead: https://constructor.slack.com/archives/CA44G41HA/p1709562698499959?thread_ts=1709314392.618379&cid=CA44G41HA
esezen
deleted the
csl-3114-node-sdk-docs-update-item-limits-for-items-api-to-10k
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the documentation to reflect the new 10k item limit when
I didn't regenerate the docs just yet. Will do so before I merge.