Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7326-JS error in editing object when a tab with list is deleted #630

Open
wants to merge 2 commits into
base: support/3.2
Choose a base branch
from

Conversation

accognet
Copy link
Contributor

@accognet accognet commented Mar 7, 2024

With this delta :
image

we have a js message:
image

@accognet accognet self-assigned this Mar 7, 2024
@accognet accognet added the bug Something isn't working label Mar 7, 2024
@accognet accognet changed the base branch from develop to support/3.2 March 7, 2024 18:05
Copy link
Contributor

@Molkobain Molkobain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you are mixing 2 different fixes in 1 PR.

@Molkobain Molkobain added the internal Work made by Combodo label Mar 8, 2024
@accognet accognet changed the title JS error in editing object when a tab with list is deleted 7326-JS error in editing object when a tab with list is deleted Mar 11, 2024
@accognet accognet force-pushed the feature/7326-Fix_remove_tab branch from ed92956 to 4fbd73d Compare March 11, 2024 07:48
@accognet
Copy link
Contributor Author

Seems like you are mixing 2 different fixes in 1 PR.

No, it's only one fix

@Molkobain
Copy link
Contributor

Then I'm not sure it's the right approach, it will be discussed during support PRs review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal Work made by Combodo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants