Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CADD annotations container path & (some) code smells #1323

Merged
merged 5 commits into from
Nov 9, 2023
Merged

fix: CADD annotations container path & (some) code smells #1323

merged 5 commits into from
Nov 9, 2023

Conversation

ivadym
Copy link
Contributor

@ivadym ivadym commented Nov 8, 2023

This PR:

String has been assigned instead of a Path for CADD annotations. There are also some code smells that we overlooked.

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

@ivadym ivadym requested a review from a team as a code owner November 8, 2023 16:12
@ivadym ivadym added the Bug Something isn't working label Nov 8, 2023
@ivadym ivadym self-assigned this Nov 8, 2023
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov Codecov
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
BALSAMIC/constants/constants.py 100.00% <100.00%> (ø)
BALSAMIC/constants/paths.py 100.00% <100.00%> (ø)
BALSAMIC/utils/analysis.py 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!

mathiasbio
mathiasbio approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@mathiasbio mathiasbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you <3 you should sell this sweet smelling code as a perfume 🌷

@ivadym ivadym merged commit 335ef88 into release_v13.0.0 Nov 9, 2023
8 checks passed
@ivadym ivadym deleted the fix-code-smells branch November 9, 2023 09:33
@ivadym ivadym mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasbio mathiasbio mathiasbio approved these changes

Assignees

@ivadym ivadym

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivadym @mathiasbio