Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Release v13.0.0 #1320

Merged
merged 165 commits into from
Jan 19, 2024
Merged

feat: Release v13.0.0 #1320

merged 165 commits into from
Jan 19, 2024

Conversation

ivadym
Copy link
Contributor

@ivadym ivadym commented Nov 6, 2023

Changelog:

Added:

Changed:

Fixed:

Removed:

ivadym and others added 30 commits February 8, 2023 14:49
@ivadym ivadym requested a review from a team as a code owner November 6, 2023 14:07
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8c45d77) 99.31% compared to head (12550ec) 99.44%.
Report is 2 commits behind head on master.

Files Patch % Lines
BALSAMIC/models/validators.py 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1320      +/-   ##
==========================================
+ Coverage   99.31%   99.44%   +0.12%     
==========================================
  Files          29       39      +10     
  Lines        1756     1974     +218     
==========================================
+ Hits         1744     1963     +219     
+ Misses         12       11       -1     
Flag Coverage Δ
unittests 99.44% <99.84%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ivadym
Copy link
Contributor Author

ivadym commented Nov 14, 2023

@Clinical-Genomics/cancer:

System integration tests:

Analysis:

Case ID Analysis type Expected QC Status
acetuna QC, tumor-only Pass Pass 🟢
civilsole WGS, tumor-only Fail (PCT_60X=0.004532) Pass 🟢
fleetjay WGS, tumor-normal Fail (PCT_60X=0.00836) Pass 🟢
setamoeba TGA, tumor-only Pass Pass 🟢
unitedbeagle TGA, tumor-normal Pass Pass 🟢
uphippo UMI, tumor-only Fail (GC dropout=1.650392 (normal sample)) Pass 🟢
equalbug UMI, tumor-normal Fail (GC_DROPOUT=1.087173 and RELATEDNESS=-0.524) Pass 🟢

Warning

Additional QC metrics failing for the UMI worklfow:

  • uphippo: QC metric PCT_TARGET_BASES_1000X: 0.861285 validation has failed. (Condition: gt 0.95, ID: ACC5611A3)
  • equalbug (tumor sample): QC metric GC_DROPOUT: 1.119042 validation has failed. (Condition: lt 1.0, ID: ACC7363A2)

Storage, delivery, and upload:

Case ID Analysis type Storage status Upload status
acetuna QC, tumor-only Pass 🟢 NA
civilsole WGS, tumor-only Pass 🟢 Pass 🟢
fleetjay WGS, tumor-normal Pass 🟢 Pass 🟢
setamoeba TGA, tumor-only Pass 🟢 Pass 🟢
unitedbeagle TGA, tumor-normal Pass 🟢 Pass 🟢
uphippo UMI, tumor-only Pass 🟢 Pass 🟢
equalbug UMI, tumor-normal Pass 🟢 Pass 🟢

Identified and corrected issues:

mathiasbio and others added 6 commits November 22, 2023 15:35
Adds updates to the ReadTheDocs mainly to reflect the additions and changes made from the GENS (#1279) and Restructuring PR (#1176).
Added:
- Picard AddReadGroup command before VarDict
- Samtools sort and index after merging reads with Sentieon Dedup

Changed: for changes in existing functionality.
- Increased memory and threads for VarDict
Removed:
- Extra samtools and index command from WGS analysis
@ivadym ivadym mentioned this pull request Jan 2, 2024
3 tasks
ivadym and others added 4 commits January 2, 2024 16:39
Removed: 
- Removed bcftools command for setting soft-filter with maximum allele-frequency, which eventually leads to a hard removal of these variants.
Copy link
Collaborator

@mathiasbio mathiasbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, took me a long time to read through all of these changes, and miraculously I found not a single typo or error anywhere. Amazing job @ivadym

(note for future generations: I'm kidding. The PRs have been reviewed already, and this can be merged when the validation report is approved)

Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

8 New issues
0 Security Hotspots
No data about Coverage
0.6% Duplication on New Code

See analysis details on SonarCloud

@mathiasbio mathiasbio merged commit 171a4f4 into master Jan 19, 2024
24 checks passed
@mathiasbio mathiasbio deleted the release_v13.0.0 branch January 19, 2024 15:28
@ivadym ivadym added the Release Release related changes label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Release related changes
Projects
Status: Archived
Development

Successfully merging this pull request may close these issues.

4 participants