Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete old proxy env vars in replicated sdk #616

Merged
merged 1 commit into from
Sep 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifests/kots-app.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ spec:
- deployment/carto-workspace-api
- deployment/carto-workspace-subscriber
- deployment/carto-workspace-www
minKotsVersion: 1.107.4
minKotsVersion: 1.117.1
additionalImages:
- gcr.io/carto-onprem-artifacts/tenant-requirements-checker:2024.4.17-rc.7
---
Expand Down
8 changes: 0 additions & 8 deletions manifests/kots-helm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -358,14 +358,6 @@ spec:
sslRejectUnauthorized: repl{{ if ConfigOptionEquals "externalHttpsProxySslCertificateCheck" "0"}}falserepl{{ else }}truerepl{{ end }}
sslCA: |
repl{{ ConfigOptionData "externalHttpsProxySslCa" | nindent 12 }}
replicated:
extraEnv:
- name: HTTP_PROXY
value: '{{repl ConfigOption "externalProxyHost" }}'
- name: HTTPS_PROXY
value: '{{repl ConfigOption "externalProxyHost" }}'
- name: NO_PROXY
value: '{{repl ConfigOption "externalProxyExcludedDomains" }}'
- when: '{{repl ConfigOptionEquals "ssoEnabled" "1"}}'
recursiveMerge: true
values:
Expand Down
Loading