Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete old proxy env vars in replicated sdk #616

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

alvarorm22
Copy link
Contributor

@alvarorm22 alvarorm22 commented Sep 19, 2024

Description of the change

The values provided to the --http-proxy, --https-proxy, and --no-proxy flags for the kots install command are now propagated to the Replicated SDK, so there is no need to add them manually.

@alvarorm22 alvarorm22 added the release-changes Deploy changes in a Replicated channel label Sep 20, 2024
Copy link

Changes release to Replicated on channel sc_441066_remove_old_replicated_sdk_extra_env_var! Check the Replicated Dashboard for more details.
If you need to test the changes, you can assign the channel to your customer and download the latest version from the Admin Console.

@alvarorm22 alvarorm22 marked this pull request as ready for review September 20, 2024 05:23
Copy link

@Keralin Keralin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarorm22 alvarorm22 merged commit 7d028a8 into main Sep 20, 2024
4 checks passed
@alvarorm22 alvarorm22 deleted the sc-441066/remove-old-replicated-sdk-extra-env-var branch September 20, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-changes Deploy changes in a Replicated channel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants