-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MinHash + Add Scalable BF #28 + Optimize Partitionned BF #53
Conversation
@Callidon Any idea to recover the length function from Partitionned Bloom Filter? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some comments and suggested changes, but otherwise it looks great. It will be a nice additions to the library, and fixes some impactful bugs. Good job 👏 👍
PS: I need to think a bit more about the length
function, but IMO, it's not an issue it disappears right now. We always were borderline with this kind of helper functions, as they are not from the original algorithms. I'm not against removing them, unless there is a real use case from user feedback. However, since we are removing a feature, we will need to release a minor or a major version after the merge.
Co-authored-by: Thomas Minier <[email protected]>
Co-authored-by: Thomas Minier <[email protected]>
Co-authored-by: Thomas Minier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for the changes, all is good for me, we can merge it alongside #54 for the next release
A major bump is required.