Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements Scalable Bloom Filter #28

Closed
Callidon opened this issue May 9, 2021 · 0 comments · Fixed by #53
Closed

Implements Scalable Bloom Filter #28

Callidon opened this issue May 9, 2021 · 0 comments · Fixed by #53
Labels
enhancement

Comments

@Callidon
Copy link
Owner

Callidon commented May 9, 2021

From #8 , we need to implements Scalable Bloom Filter, since the partitioned bloom filter is fixed now the Scalable bloom filter can be easily implemented.
@folkvir folkvir mentioned this issue Mar 23, 2022
Merged
@Callidon Callidon linked a pull request Mar 25, 2022 that will close this issue
Fix MinHash + Add Scalable BF #28 + Optimize Partitionned BF #53
Merged
folkvir added a commit that referenced this issue Mar 26, 2022
@folkvir
Fix MinHash + Add Scalable BF #28 + Optimize Partitionned BF (#53)
1d37e81 
* set BitSet optimization for partitioned bloom filter

* add the scalable bloom filter based of partitionned bloom filter

* add scalable bloom filter + docs

* fix: minhash comparison was wrong

* update and fix changelog

* remove use strict;

* typos #53

* equals/if suggestion of #53

* suggestion #53 simplify logic of the SBF.has()

* lint + update readme (suggestion of #53 on PRs

* doc on bitset import for PBF and BF (suggestion of #53)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix MinHash + Add Scalable BF #28 + Optimize Partitionned BF Callidon/bloom-filters
1 participant
@Callidon