Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third party registry setup #8

Merged
merged 5 commits into from
Feb 8, 2024
Merged

Third party registry setup #8

merged 5 commits into from
Feb 8, 2024

Conversation

DivadNojnarg
Copy link
Contributor

Fix #5

@DivadNojnarg DivadNojnarg self-assigned this Feb 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

Attention: 119 lines in your changes are missing coverage. Please review.

Comparison is base (904650f) 38.53% compared to head (7260740) 30.35%.

❗ Current head 7260740 differs from pull request most recent head 4de756e. Consider uploading reports for the commit 4de756e to get more accurate results

Files Patch % Lines
R/utils.R 0.00% 94 Missing ⚠️
R/demo-bms-blocks.R 0.00% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   38.53%   30.35%   -8.19%     
==========================================
  Files           6        6              
  Lines         397      504     +107     
==========================================
  Hits          153      153              
- Misses        244      351     +107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DivadNojnarg DivadNojnarg mentioned this pull request Feb 8, 2024
@DivadNojnarg
Copy link
Contributor Author

@JohnCoene: can you confirm what block you need for the demo (i.e. do you still need all the demo blocks like demo_arrange_block or the outdated monolithic ggiraph/plot block)? Do you also need custom data blocks like:

lab_data_block <- function(...) {
  initialize_block(new_data_block(
    ...,
    dat = as.environment("package:blockr.data"),
    selected = "lab"
  ))
}

For now, I included all of them except the one in #9.

@JohnCoene
Copy link
Member

@DivadNojnarg I'm not doing the demo, @karmatarap is handling that, we can confirm with him but I do not think demo blocks are needed.

@JohnCoene
Copy link
Member

@DivadNojnarg may we merge this?

@DivadNojnarg
Copy link
Contributor Author

Yes I was checking the blocks. The plot_code_block will also suffer from the same issue we have in {blockr} (not for ggplot).

@DivadNojnarg DivadNojnarg merged commit dc47a51 into main Feb 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use blocks from blockr.extra in registry
3 participants