-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: split up refund page #785
Changes from all commits
a9ddde7
bd71ccb
c7bb7d3
4b43d3c
a40bd5d
362c391
2b95b9f
52b9097
a57f849
efba188
06cd04c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,6 +25,7 @@ import NotFound from "./pages/NotFound"; | |
import Pay from "./pages/Pay"; | ||
import Refund from "./pages/Refund"; | ||
import RefundEvm from "./pages/RefundEvm"; | ||
import RefundExternal from "./pages/RefundExternal"; | ||
import RefundStep from "./pages/RefundStep"; | ||
import "./style/index.scss"; | ||
import "./utils/patches"; | ||
|
@@ -105,6 +106,8 @@ const cleanup = render( | |
<Route path="/swap/refund/:id" component={RefundStep} /> | ||
<Route path="/error" component={() => <Error />} /> | ||
<Route path="/refund" component={Refund} /> | ||
<Route path="/refund/external" component={RefundExternal} /> | ||
<Route path="/refund/external/:type" component={RefundExternal} /> | ||
Comment on lines
+109
to
+110
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure if we should have There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Otherwise, we would have to naviate to |
||
<Route path="/history" component={History} /> | ||
<Route path="*404" component={NotFound} /> | ||
</Router> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does
unresolved
mean in this context?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its the initial state before it has been fetched for the first time.
Since we know pass the swap to the resource as a source signal it only fetches once populated (and refetches when it changes)