refactor: split up refund page #785
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jackstar12
force-pushed
the
refactor/refund-page
branch
from
837ba12 to
c09af6a
Compare
jackstar12
force-pushed
the
refactor/refund-page
branch
from
c09af6a to
b19bb57
Compare
jackstar12
force-pushed
the
refactor/refund-page
branch
from
b19bb57 to
cc5595b
Compare
jackstar12
force-pushed
the
refactor/refund-page
branch
2 times, most recently
from
135b5ca to
44b4c57
Compare
jackstar12
force-pushed
the
refactor/refund-page
branch
from
44b4c57 to
a9ddde7
Compare
There was a problem hiding this comment.
Minor wording discrepancies with Figma in many places:
- Landing title should be "Refund Swap" not "Refund a swap", please check all figma screens. Add fullstops etc.
Also:
- Bitcoin/Liquid should have address field and refund button on empty state already and not have it appear automagically after selecting refund file (as we have it rn)
- I forgot to include this error state in the wireframe, but here the sentence should say "Please switch your wallet network to Rootstock"
Other than that awesome improvement, I really like this:
|
@kilrau addressed all except the last one - will be in a follow up pr. |
|
and let's fix this CI 💪 |
What about address validation in that case? |
disable it, enable it once a valid refund file was parsed |
|
Created follow up issue for my review: #793 So here only CI is missing. |
jackstar12
force-pushed
the
refactor/refund-page
branch
from
e19c6b5 to
a57f849
Compare
| <Match | ||
| when={ | ||
| lockupTransaction.state === "ready" || | ||
| lockupTransaction.state == "unresolved" |
There was a problem hiding this comment.
What does unresolved mean in this context?
There was a problem hiding this comment.
Its the initial state before it has been fetched for the first time.
Since we know pass the swap to the resource as a source signal it only fetches once populated (and refetches when it changes)
closes: #747
Also removes the link to the existing swap upon refund file upload if its found within browser history - its simply handled the same as all other refund files.