Two new prayers in UUB O Etiop 46 #1397
Merged
+158
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karljonaskarlsson
requested review from
eu-genia,
nafisa-valieva and
CarstenHoffmannMarburg
eu-genia
reviewed
Jan 16, 2025
new/LIT7250PPFanuel.xml
Outdated
| <div xml:lang="gez" type="edition"> | ||
| <note>Below, the full text is reproduced based on <ref type="mss" corresp="UppEt46"/>.</note> | ||
| <div type="edition"> | ||
| <ab> |
There was a problem hiding this comment.
it is better to use lg for stanzas instead of ab
new/LIT7250PPFanuel.xml
Outdated
| <l n="3">አልብሰኒ፡ ጽድቀ፡ ለዓለመ፡ <sic resp="JK">ዓለመ፡</sic> ወዓዲ፡</l> | ||
| <l n="4">ወበትንባሌከ፡ እደ። ኃጣውእየ፡ ፍዲ፡</l> | ||
| <l n="5">መናሥግተ፡ ቤትየ፡ አጽንዕ፡ ኢይባእ፡ ረዋዲ፡</l> | ||
| ኦአምላከ፡ ፋኑኤል፡ ዕቀባ፡ እምዓይነተ፡ ባርያ፡ ወ |
There was a problem hiding this comment.
and the last line is not a line?
There was a problem hiding this comment.
It's not rhymed and, as we know, such verses usually consist of five lines, so not marking it up as <l n="6"> was a conscious decision. But do you think it will look weird like this?
There was a problem hiding this comment.
I'll mark it up as Line 6 for the sake of the encoding – it doesn't really make any difference contentwise.
CarstenHoffmannMarburg
approved these changes
Jan 17, 2025
eu-genia
approved these changes
Jan 17, 2025
karljonaskarlsson
deleted the
2025-01-16-JK-Two-more-works-UUB-O-Etiop-46
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new prayers based on:
BetaMasaheft/Documentation#2775
BetaMasaheft/Documentation#2776