Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Kingdom decision sync #755

Draft
wants to merge 17 commits into
base: development
Choose a base branch
from

Conversation

WakooMan
Copy link
Contributor

@WakooMan WakooMan commented Feb 7, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • All new classes have class-level documentation comments, if there are any at all
  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation update
  • Other... Please describe:

What is the current behaviour?

What is the new behaviour?

Resolves #748 #671

  • KingdomDecisions can be serialized now.
  • AddDecision and RemoveDecision method is now synced.

Other information

@WakooMan WakooMan self-assigned this Feb 7, 2024
@WakooMan WakooMan force-pushed the features/Kingdom-Decision-Sync branch from 446cc56 to e000b27 Compare February 9, 2024 16:51
@WakooMan WakooMan changed the title WIP: Kingdom decision sync Kingdom decision sync Feb 9, 2024
@WakooMan WakooMan linked an issue Feb 9, 2024 that may be closed by this pull request
2 tasks
@WakooMan WakooMan changed the title Kingdom decision sync WIP: Kingdom decision sync Feb 12, 2024
@garrettluskey garrettluskey marked this pull request as draft February 17, 2024 19:27
Copy link
Contributor

@garrettluskey garrettluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fix conflicts and good to go

Allow origianl has been condensed to the following

// Skip if we called it
if (CallOriginalPolicy.IsOriginalAllowed()) return true;

@WakooMan WakooMan force-pushed the features/Kingdom-Decision-Sync branch from 0404ddb to 828b900 Compare June 14, 2024 05:13
@WakooMan WakooMan force-pushed the features/Kingdom-Decision-Sync branch from 7aa8c56 to d506858 Compare June 22, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KingdomDecision Protobuf Serializers Kingdom Decisions Sync
3 participants