Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kingdom Decisions Sync #671

Open
2 tasks
EgardA opened this issue Sep 27, 2023 · 0 comments · May be fixed by #755
Open
2 tasks

Kingdom Decisions Sync #671

EgardA opened this issue Sep 27, 2023 · 0 comments · May be fixed by #755
Assignees
Labels
enhancement New feature or request

Comments

@EgardA
Copy link
Contributor

EgardA commented Sep 27, 2023

For New Contributors

How to contribute

Description

Kingdom.RemoveDecision()
Kingdom.AddDecision()

Sync needed for Settlement Ownership Change

Intended Design

Follow design of this to get a sense of how to do start out and then follow the messages to keep going :)

https://github.com/Bannerlord-Coop-Team/BannerlordCoop/blob/587e19101cbb14f398aef04f6599b117acc0e48f/source/GameInterface/Services/Settlements/Patches/ChangeOwnerOfSettlementPatch.cs

Location

Follow above as well.

Related Issues

Requirements

Create an integration test for your messages

Additional information

Ask in contrib-chat if you require any assistance, we are happy to help you out.

Definition of Done

  • Class level comments exist for all new classes.
  • XUnit tests exist for every method that does not require the game to be ran.
@EgardA EgardA added the enhancement New feature or request label Sep 27, 2023
@WakooMan WakooMan self-assigned this Jan 29, 2024
@WakooMan WakooMan linked a pull request Feb 7, 2024 that will close this issue
10 tasks
@WakooMan WakooMan linked a pull request Feb 9, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Workable
Status: In Progress
Status: Todo
Development

Successfully merging a pull request may close this issue.

2 participants