Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark all AppConfig SDK client methods as const, since clients are immutable. #6328

Merged
merged 1 commit into from
Jan 11, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -39,115 +39,115 @@ namespace Azure { namespace Data { namespace AppConfiguration {
GetKeysPagedResponse GetKeys(
std::string const& accept,
GetKeysOptions const& options = {},
Core::Context const& context = {});
Core::Context const& context = {}) const;

Response<CheckKeysResult> CheckKeys(
CheckKeysOptions const& options = {},
Core::Context const& context = {});
Core::Context const& context = {}) const;

GetKeyValuesPagedResponse GetKeyValues(
std::string const& accept,
GetKeyValuesOptions const& options = {},
Core::Context const& context = {});
Core::Context const& context = {}) const;

Response<CheckKeyValuesResult> CheckKeyValues(
CheckKeyValuesOptions const& options = {},
Core::Context const& context = {});
Core::Context const& context = {}) const;

Response<GetKeyValueResult> GetKeyValue(
std::string const& key,
std::string const& accept,
GetKeyValueOptions const& options = {},
Core::Context const& context = {});
Core::Context const& context = {}) const;

Response<PutKeyValueResult> PutKeyValue(
PutKeyValueRequestContentType const& contentType,
std::string const& key,
std::string const& accept,
PutKeyValueOptions const& options = {},
Core::Context const& context = {});
Core::Context const& context = {}) const;

Response<DeleteKeyValueResult> DeleteKeyValue(
std::string const& key,
std::string const& accept,
DeleteKeyValueOptions const& options = {},
Core::Context const& context = {});
Core::Context const& context = {}) const;

Response<CheckKeyValueResult> CheckKeyValue(
std::string const& key,
CheckKeyValueOptions const& options = {},
Core::Context const& context = {});
Core::Context const& context = {}) const;

GetSnapshotsPagedResponse GetSnapshots(
std::string const& accept,
GetSnapshotsOptions const& options = {},
Core::Context const& context = {});
Core::Context const& context = {}) const;

Response<CheckSnapshotsResult> CheckSnapshots(
CheckSnapshotsOptions const& options = {},
Core::Context const& context = {});
Core::Context const& context = {}) const;

Response<GetSnapshotResult> GetSnapshot(
std::string const& name,
std::string const& accept,
GetSnapshotOptions const& options = {},
Core::Context const& context = {});
Core::Context const& context = {}) const;

Response<OperationDetails> GetOperationDetails(
std::string const& snapshot,
GetOperationDetailsOptions const& options = {},
Core::Context const& context = {});
Core::Context const& context = {}) const;

Response<CreateSnapshotResult> CreateSnapshot(
CreateSnapshotRequestContentType const& contentType,
std::string const& name,
std::string const& accept,
Snapshot const& entity,
CreateSnapshotOptions const& options = {},
Core::Context const& context = {});
Core::Context const& context = {}) const;

Response<UpdateSnapshotResult> UpdateSnapshot(
UpdateSnapshotRequestContentType const& contentType,
std::string const& name,
std::string const& accept,
SnapshotUpdateParameters const& entity,
UpdateSnapshotOptions const& options = {},
Core::Context const& context = {});
Core::Context const& context = {}) const;

Response<CheckSnapshotResult> CheckSnapshot(
std::string const& name,
CheckSnapshotOptions const& options = {},
Core::Context const& context = {});
Core::Context const& context = {}) const;

GetLabelsPagedResponse GetLabels(
std::string const& accept,
GetLabelsOptions const& options = {},
Core::Context const& context = {});
Core::Context const& context = {}) const;

Response<CheckLabelsResult> CheckLabels(
CheckLabelsOptions const& options = {},
Core::Context const& context = {});
Core::Context const& context = {}) const;

Response<PutLockResult> PutLock(
std::string const& key,
std::string const& accept,
PutLockOptions const& options = {},
Core::Context const& context = {});
Core::Context const& context = {}) const;

Response<DeleteLockResult> DeleteLock(
std::string const& key,
std::string const& accept,
DeleteLockOptions const& options = {},
Core::Context const& context = {});
Core::Context const& context = {}) const;

GetRevisionsPagedResponse GetRevisions(
std::string const& accept,
GetRevisionsOptions const& options = {},
Core::Context const& context = {});
Core::Context const& context = {}) const;

Response<CheckRevisionsResult> CheckRevisions(
CheckRevisionsOptions const& options = {},
Core::Context const& context = {});
Core::Context const& context = {}) const;

private:
std::shared_ptr<Core::Http::_internal::HttpPipeline> m_pipeline;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ std::string ConfigurationClient::GetUrl() const { return m_url.GetAbsoluteUrl();
GetKeysPagedResponse ConfigurationClient::GetKeys(
std::string const& accept,
GetKeysOptions const& options,
Core::Context const& context)
Core::Context const& context) const
{
auto url = m_url;
url.AppendPath("keys");
Expand Down Expand Up @@ -266,7 +266,7 @@ GetKeysPagedResponse ConfigurationClient::GetKeys(

Azure::Response<CheckKeysResult> ConfigurationClient::CheckKeys(
CheckKeysOptions const& options,
Core::Context const& context)
Core::Context const& context) const
{
auto url = m_url;
url.AppendPath("keys");
Expand Down Expand Up @@ -298,7 +298,7 @@ Azure::Response<CheckKeysResult> ConfigurationClient::CheckKeys(
GetKeyValuesPagedResponse ConfigurationClient::GetKeyValues(
std::string const& accept,
GetKeyValuesOptions const& options,
Core::Context const& context)
Core::Context const& context) const
{
auto url = m_url;
url.AppendPath("kv");
Expand Down Expand Up @@ -455,7 +455,7 @@ GetKeyValuesPagedResponse ConfigurationClient::GetKeyValues(

Azure::Response<CheckKeyValuesResult> ConfigurationClient::CheckKeyValues(
CheckKeyValuesOptions const& options,
Core::Context const& context)
Core::Context const& context) const
{
auto url = m_url;
url.AppendPath("kv");
Expand Down Expand Up @@ -523,7 +523,7 @@ Azure::Response<GetKeyValueResult> ConfigurationClient::GetKeyValue(
std::string const& key,
std::string const& accept,
GetKeyValueOptions const& options,
Core::Context const& context)
Core::Context const& context) const
{
auto url = m_url;
url.AppendPath("kv/");
Expand Down Expand Up @@ -631,7 +631,7 @@ Azure::Response<PutKeyValueResult> ConfigurationClient::PutKeyValue(
std::string const& key,
std::string const& accept,
PutKeyValueOptions const& options,
Core::Context const& context)
Core::Context const& context) const
{
auto url = m_url;
url.AppendPath("kv/");
Expand Down Expand Up @@ -774,7 +774,7 @@ Azure::Response<DeleteKeyValueResult> ConfigurationClient::DeleteKeyValue(
std::string const& key,
std::string const& accept,
DeleteKeyValueOptions const& options,
Core::Context const& context)
Core::Context const& context) const
{
auto url = m_url;
url.AppendPath("kv/");
Expand Down Expand Up @@ -862,7 +862,7 @@ Azure::Response<DeleteKeyValueResult> ConfigurationClient::DeleteKeyValue(
Azure::Response<CheckKeyValueResult> ConfigurationClient::CheckKeyValue(
std::string const& key,
CheckKeyValueOptions const& options,
Core::Context const& context)
Core::Context const& context) const
{
auto url = m_url;
url.AppendPath("kv/");
Expand Down Expand Up @@ -912,7 +912,7 @@ Azure::Response<CheckKeyValueResult> ConfigurationClient::CheckKeyValue(
GetSnapshotsPagedResponse ConfigurationClient::GetSnapshots(
std::string const& accept,
GetSnapshotsOptions const& options,
Core::Context const& context)
Core::Context const& context) const
{
auto url = m_url;
url.AppendPath("snapshots");
Expand Down Expand Up @@ -1102,7 +1102,7 @@ GetSnapshotsPagedResponse ConfigurationClient::GetSnapshots(

Azure::Response<CheckSnapshotsResult> ConfigurationClient::CheckSnapshots(
CheckSnapshotsOptions const& options,
Core::Context const& context)
Core::Context const& context) const
{
auto url = m_url;
url.AppendPath("snapshots");
Expand Down Expand Up @@ -1133,7 +1133,7 @@ Azure::Response<GetSnapshotResult> ConfigurationClient::GetSnapshot(
std::string const& name,
std::string const& accept,
GetSnapshotOptions const& options,
Core::Context const& context)
Core::Context const& context) const
{
auto url = m_url;
url.AppendPath("snapshots/");
Expand Down Expand Up @@ -1282,7 +1282,7 @@ Azure::Response<GetSnapshotResult> ConfigurationClient::GetSnapshot(
Azure::Response<OperationDetails> ConfigurationClient::GetOperationDetails(
std::string const& snapshot,
GetOperationDetailsOptions const& options,
Core::Context const& context)
Core::Context const& context) const
{
auto url = m_url;
url.AppendPath("operations");
Expand Down Expand Up @@ -1382,7 +1382,7 @@ Azure::Response<CreateSnapshotResult> ConfigurationClient::CreateSnapshot(
std::string const& accept,
Snapshot const& entity,
CreateSnapshotOptions const& options,
Core::Context const& context)
Core::Context const& context) const
{
auto url = m_url;
url.AppendPath("snapshots/");
Expand Down Expand Up @@ -1597,7 +1597,7 @@ Azure::Response<UpdateSnapshotResult> ConfigurationClient::UpdateSnapshot(
std::string const& accept,
SnapshotUpdateParameters const& entity,
UpdateSnapshotOptions const& options,
Core::Context const& context)
Core::Context const& context) const
{
auto url = m_url;
url.AppendPath("snapshots/");
Expand Down Expand Up @@ -1747,7 +1747,7 @@ Azure::Response<UpdateSnapshotResult> ConfigurationClient::UpdateSnapshot(
Azure::Response<CheckSnapshotResult> ConfigurationClient::CheckSnapshot(
std::string const& name,
CheckSnapshotOptions const& options,
Core::Context const& context)
Core::Context const& context) const
{
auto url = m_url;
url.AppendPath("snapshots/");
Expand Down Expand Up @@ -1781,7 +1781,7 @@ Azure::Response<CheckSnapshotResult> ConfigurationClient::CheckSnapshot(
GetLabelsPagedResponse ConfigurationClient::GetLabels(
std::string const& accept,
GetLabelsOptions const& options,
Core::Context const& context)
Core::Context const& context) const
{
auto url = m_url;
url.AppendPath("labels");
Expand Down Expand Up @@ -1873,7 +1873,7 @@ GetLabelsPagedResponse ConfigurationClient::GetLabels(

Azure::Response<CheckLabelsResult> ConfigurationClient::CheckLabels(
CheckLabelsOptions const& options,
Core::Context const& context)
Core::Context const& context) const
{
auto url = m_url;
url.AppendPath("labels");
Expand Down Expand Up @@ -1921,7 +1921,7 @@ Azure::Response<PutLockResult> ConfigurationClient::PutLock(
std::string const& key,
std::string const& accept,
PutLockOptions const& options,
Core::Context const& context)
Core::Context const& context) const
{
auto url = m_url;
url.AppendPath("locks/");
Expand Down Expand Up @@ -2010,7 +2010,7 @@ Azure::Response<DeleteLockResult> ConfigurationClient::DeleteLock(
std::string const& key,
std::string const& accept,
DeleteLockOptions const& options,
Core::Context const& context)
Core::Context const& context) const
{
auto url = m_url;
url.AppendPath("locks/");
Expand Down Expand Up @@ -2098,7 +2098,7 @@ Azure::Response<DeleteLockResult> ConfigurationClient::DeleteLock(
GetRevisionsPagedResponse ConfigurationClient::GetRevisions(
std::string const& accept,
GetRevisionsOptions const& options,
Core::Context const& context)
Core::Context const& context) const
{
auto url = m_url;
url.AppendPath("revisions");
Expand Down Expand Up @@ -2253,7 +2253,7 @@ GetRevisionsPagedResponse ConfigurationClient::GetRevisions(

Azure::Response<CheckRevisionsResult> ConfigurationClient::CheckRevisions(
CheckRevisionsOptions const& options,
Core::Context const& context)
Core::Context const& context) const
{
auto url = m_url;
url.AppendPath("revisions");
Expand Down
Loading