Mark all AppConfig SDK client methods as const, since clients are immutable. #6328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahsonkhan
requested review from
LarryOsterman,
antkmsft,
gearama and
RickWinter
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
This was referenced Jan 9, 2025
antkmsft
approved these changes
Jan 10, 2025
|
Are you planning on adding tests for a const AppConfig client? |
LarryOsterman
approved these changes
Jan 10, 2025
Yes, once we have runnable samples that pass without exceptions and functional tests for the generated code, I will make sure to use const instances of the client in those tests: |
LarryOsterman
pushed a commit
to LarryOsterman/azure-sdk-for-cpp
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/Azure/autorest.cpp/issues/464
Checking to see if const poisoning causes any unexpected build issues, across platforms.