Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics-server and addon-resizer images from MCR oss/v2 #5140

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions parts/linux/cloud-init/artifacts/components.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,16 @@
}
]
},
{
"downloadURL": "mcr.microsoft.com/oss/v2/kubernetes/addon-resizer:*",
"amd64OnlyVersions": [],
"multiArchVersionsV2": [
{
"renovateTag": "registry=https://mcr.microsoft.com, name=oss/v2/kubernetes/addon-resizer",
"latestVersion": "v1.8.22-2"
}
]
},
{
"downloadURL": "mcr.microsoft.com/oss/kubernetes/pause:*",
"amd64OnlyVersions": [],
Expand Down Expand Up @@ -45,6 +55,20 @@
}
]
},
{
"downloadURL": "mcr.microsoft.com/oss/v2/kubernetes/metrics-server:*",
"amd64OnlyVersions": [],
"multiArchVersionsV2": [
{
"renovateTag": "registry=https://mcr.microsoft.com, name=oss/v2/kubernetes/metrics-server",
"latestVersion": "v0.7.2-3"
},
{
"renovateTag": "registry=https://mcr.microsoft.com, name=oss/v2/kubernetes/metrics-server",
"latestVersion": "v0.6.3-2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we had previously been caching an unused version of metrics-server until recently - are both of these versions absolutely necessary?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the other thing is that metrics-server will only be running on a couple nodes in the system pool at most at any given time

@djsly do you think we should bring this back or leave it out?

Copy link
Collaborator Author

@SriHarsha001 SriHarsha001 Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested these images on all AKS versions (1.27, 1.28, 1.29. 1.30 and 1.31) and will be rolling out these images to metrics-server pods in AKS clusters. These images have all the fixes for currently reported CVEs.

}
]
},
{
"downloadURL": "mcr.microsoft.com/containernetworking/azure-cni:*",
"amd64OnlyVersions": [],
Expand Down
Loading