-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metrics-server and addon-resizer images from MCR oss/v2 #5140
Conversation
}, | ||
{ | ||
"renovateTag": "registry=https://mcr.microsoft.com, name=oss/v2/kubernetes/metrics-server", | ||
"latestVersion": "v0.6.3-2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we had previously been caching an unused version of metrics-server until recently - are both of these versions absolutely necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the other thing is that metrics-server will only be running on a couple nodes in the system pool at most at any given time
@djsly do you think we should bring this back or leave it out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested these images on all AKS versions (1.27, 1.28, 1.29. 1.30 and 1.31) and will be rolling out these images to metrics-server pods in AKS clusters. These images have all the fixes for currently reported CVEs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In terms of syntax, it looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed with @djsly offline that we will no longer be caching metrics-server
What type of PR is this?
I have created, tested and published metrics-server images v0.7.2-3 and v0.6.3-2 to MCR using the new Dalec framework. The new Dalec framework publish the images to MCR under oss/v2 path. We plan to use v0.7.2-3 on all AKS clusters with 1.31 versions and existing clusters will use v0.6.3-2. All AKS clusters will use v1.8.22-2 version or Addon-Resizer.
mcr.microsoft.com/oss/v2/kubernetes/metrics-server:v0.7.2-3
mcr.microsoft.com/oss/v2/kubernetes/metrics-server:v0.6.3-2
mcr.microsoft.com/oss/v2/kubernetes/autoscaler/addon-resizer:v1.8.22-2
What this PR does / why we need it:
These image have fixes for all the CVEs. I plan to rollout these images to AKS cluster and need to cache the images on VHD.
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
https://mcr.microsoft.com/en-us/artifact/mar/oss/v2/kubernetes/autoscaler/addon-resizer/tags
https://mcr.microsoft.com/en-us/artifact/mar/oss/v2/kubernetes/metrics-server/tags
Release note: