Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launchpad My Home: Showing snackbar when a task was completed #98865

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

vykes-mac
Copy link
Contributor

@vykes-mac vykes-mac commented Jan 24, 2025

Related to #98839

Proposed Changes

  • Show onboarding launchpad next step snackbar when publishing first post.

image

Why are these changes being made?

Testing Instructions

  • Apply this branch on your local Calypso

  • Make sure widgets.wp.com is sandboxed.

  • Run install-plugin.sh wbe add/task-next-step-snackbar on sandbox

  • Create a new post using the onboarding flag: http://calypso.localhost:3000/post/{domain}?#publish-first-post

  • Inspect the page and open the iFrame URL in a new tab
    https://{siteSlug}/wp-admin/post.php?post=44&action=edit&calypsoify=1&block-editor=1&frame-nonce=ed0785d2f4&origin=http%3A%2F%2Fcalypso.localhost%3A3000&environment-id=development&support_user=&_support_token#publish-first-post

  • After publishing a post, you should see a snackbar with next steps link

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@vykes-mac vykes-mac changed the title Launchpad My Home: Showing snackbar when a task was completed WIP Launchpad My Home: Showing snackbar when a task was completed Jan 24, 2025
@matticbot
Copy link
Contributor

matticbot commented Jan 24, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/task-next-step-snackbar on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@vykes-mac vykes-mac changed the title WIP Launchpad My Home: Showing snackbar when a task was completed Launchpad My Home: Showing snackbar when a task was completed Jan 25, 2025
@vykes-mac vykes-mac marked this pull request as ready for review January 25, 2025 01:52
@vykes-mac vykes-mac self-assigned this Jan 25, 2025
@vykes-mac vykes-mac added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 25, 2025
@vykes-mac vykes-mac requested a review from paulopmt1 January 25, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants