-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newsletter Tasks: Complete 'Start building your audience' upon browsing the page #98869
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~317 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really like the hook approach 👍 I'll make a couple tweaks
noticeDuration?: number; | ||
} | ||
|
||
export const useTaskCompletedNotice = ( { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice wee hook, I like this approach 👍
Since the completion logic is unique for each task, I sort of wanted to have a different hook name, that made it clear that this hook was appropriate when the task is completed on navigation.
export const useTaskCompletedNotice = ( { | |
export const useTaskCompletedOnNavigationNotice = ( { |
But this seems too clunky. So I think just leave it for now until something better becomes obvious.
I've made a change so that the client users a URL hash for determining whether the task should completed (rather than a feature flag). Depends on Automattic/jetpack#41299 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's working as expected, nice work!
I raised a concern about the UX here: p1737727052353399-slack-C057AH42XQD
Nice work here! Did a similar thing here #98865, I'll work with your hook instead! Nice ✨ |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17208912 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @zaguiini for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Closes #98775.
Registrazione.schermo.2025-01-24.alle.12.04.57.AM.mov
Testing Instructions
/setup/onboarding
flow.You'll end up in
/home/%s
and the checklist task should be ticked.