Tools: uploader.py: verify correct install

[rafasaurus]

• Implement functionality to verify correct firmware installation
• Utilize existing code with an additional argument for verification

[peterbarker]

"verify" is really, "verify that the flash worked".

You're re-using the functionality, but that terminology isn't really applicable in this case.

I'm OK with the current name of the parameter, but if we can find something better that would be good!

--assert-firmware-is would work, but a little verbose

In any case, a slightly better description is called for...

[peterbarker]

... also, please fold all of this into the one commit . The one starting with Tools: looks appropriate.

[rafasaurus]

... also, please fold all of this into the one commit . The one starting with Tools: looks appropriate.

Should we just squash and merge?

[peterbarker]

Please avoid merge commits in your history - this needs a rebase again.

I've also requested a change you suggested yourself. I think the suggestion makes it unambiguous what the new feature does?

[rafasaurus]

Please avoid merge commits in your history - this needs a rebase again.

I've also requested a change you suggested yourself. I think the suggestion makes it unambiguous what the new feature does?

Changed, rebased and tested on the board.