Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2: Update from Humble to Jazzy #29139

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

andrewkwolek
Copy link

I made some changes to make the repo compatible with Jazzy Jalisco which is the most recent build of ROS2. Most of these changes involved changing dependencies from humble to jazzy. I also changed micro_ros_agent to use the jazzy branch instead of the humble branch in Tools/ros2/ros2.repos.

I was able to successfully run the installation and SITL in the documentation (https://ardupilot.org/dev/docs/ros2-sitl.html). This did not take much time, so it makes me curious why this hasn't been done yet? It is possible there are some low level changes that need to be made that I am unaware of. Thanks!

@andrewkwolek
Copy link
Author

Looks like the container used for colcon build/test / build-test (pull_request) does not have jazzy installed on it.

@andrewkwolek
Copy link
Author

Is there a way to change the container https://github.com/ArduPilot/ardupilot_dev_docker/blob/master/docker/Dockerfile_dev-ros that the colcon.yml test uses to have jazzy installed instead of humble?

@Ryanf55 Ryanf55 added the ROS label Jan 26, 2025
Copy link
Collaborator

@Ryanf55 Ryanf55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's on our radar to migrate to Jazzy, but we haven't decided how to do that.

Your PR is a proposal to migrate immediately, without warning, and have no support of humble anymore, at least from CI. I propose we be a little more conservative, and find a way to phase the migration in.

.github/workflows/colcon.yml Outdated Show resolved Hide resolved
Tools/ros2/ros2.repos Outdated Show resolved Hide resolved
@andrewkwolek
Copy link
Author

One note. The container container: image: ardupilot/ardupilot-dev-ros:latest that colcon.yml runs on is set to test humble. I don't know if there is a way to run two different images from one Docker file so we may need an arupilot-dev-ros-jazzy and ardupilot-ros-dev-humble container. Does that sound okay?

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Jan 26, 2025

Yes that's ok we can add containers like that.

@andrewkwolek
Copy link
Author

andrewkwolek commented Jan 26, 2025

@Ryanf55 I made this PR in ardupilot_dev_docker: ArduPilot/ardupilot_dev_docker#33 as it would also need to be implemented in order to properly test both jazzy and humble. I implemented the matrix build so feel free to take a look.

@andrewkwolek
Copy link
Author

@Ryanf55 I added the options field with the --build-arg ROS-VERSION=${version} tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants