-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROS2: Update from Humble to Jazzy #29139
base: master
Are you sure you want to change the base?
Conversation
Looks like the container used for colcon build/test / build-test (pull_request) does not have jazzy installed on it. |
Is there a way to change the container https://github.com/ArduPilot/ardupilot_dev_docker/blob/master/docker/Dockerfile_dev-ros that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It's on our radar to migrate to Jazzy, but we haven't decided how to do that.
Your PR is a proposal to migrate immediately, without warning, and have no support of humble
anymore, at least from CI. I propose we be a little more conservative, and find a way to phase the migration in.
One note. The container |
Yes that's ok we can add containers like that. |
@Ryanf55 I made this PR in |
@Ryanf55 I added the |
I made some changes to make the repo compatible with Jazzy Jalisco which is the most recent build of ROS2. Most of these changes involved changing dependencies from
humble
tojazzy
. I also changed micro_ros_agent to use the jazzy branch instead of the humble branch in Tools/ros2/ros2.repos.I was able to successfully run the installation and SITL in the documentation (https://ardupilot.org/dev/docs/ros2-sitl.html). This did not take much time, so it makes me curious why this hasn't been done yet? It is possible there are some low level changes that need to be made that I am unaware of. Thanks!