869 - Update test_create_portal_metadata to use assertProjectReadmeContent #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nten, update regex pattern in assertProjectReadmeContent, generate test_data/readmes/PORTAL_ALL_METADATA.md, update the value of common.PORTAL_METADATA_COMPUTED_FILE_NAME from portal_metadata.zip to PORTAL_ALL_METADATA.zip
…L_ALL_METADATA.md
nozomione
commented
Sep 11, 2024
| @@ -73,7 +73,7 @@ def get_updated_content(content: str) -> str: | |||
| return content.strip() | |||
|
|
|||
| # Get the corresponding saved readme output path based on the zip filename | |||
| readme_filename = re.sub(r"^[A-Z\d]+_", "", Path(zip_file.filename).stem) + ".md" | |||
| readme_filename = re.sub(r"^[A-Z]{5}\d{6}_", "", Path(zip_file.filename).stem) + ".md" | |||
There was a problem hiding this comment.
I've made the regex pattern more explicit for IDs (e.g., SCPCP999990) and adjusted this file as well.
There was a problem hiding this comment.
We will remove this when we extract these checks into test_readme_file
davidsmejia
approved these changes
Sep 11, 2024
nozomione
deleted the
nozomione/869-update-readme-assertion-method-for-test-create-portal-metadata
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Closing #869
Purpose/Implementation Notes
I've update the
create_portal_metadatamanagement command test to use the newassertProjectReadmeContentmethod.Changes include:
test_data/readmes/PORTAL_ALL_METADATA.mdcommon.PORTAL_METADATA_COMPUTED_FILE_NAMEvalue fromportal_metadata.ziptoPORTAL_ALL_METADATA.zipassertProjectReadmeContent(made it more explicit forPROJECTID_)assertProjectReadmeContainswithassertProjectReadmeContentintest_create_portal_metadatatemplates/readme/contents/METADATA_ONLY.mdto produce the valid readme outputTypes of changes
Functional tests
N/A
Checklist
Screenshots
N/A