Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_create_portal_metadata to use assertProjectReadmeContent #869

Closed
nozomione opened this issue Aug 29, 2024 · 0 comments · Fixed by #892
Closed

Update test_create_portal_metadata to use assertProjectReadmeContent #869

nozomione opened this issue Aug 29, 2024 · 0 comments · Fixed by #892
Assignees
Labels

Comments

@nozomione
Copy link
Member

nozomione commented Aug 29, 2024

Context

Parent issue: #708

Feature branch: feature/portal-metadata-command

With the merge of feature/consolidate-readmes into dev, we introduced a new method for testing readme file correctness, assertProjectReadmeContent. This method replaced the previous assertProjectReadmeContains, which checked for specific strings within readme files. The new method performs a line-by-line comparison to make sure the format and content of the expected and output readme files are identical.

Problem or idea

The test for the portal metadata readme file is still using the outdated assertProjectReadmeContains method. To align with the new changes and verify the accuracy of the portal metadata readme file, we need to adjust the create_portal_metadata management command test to use the new assertProjectReadmeContent method.

Solution or next step

  1. Generate the portal metadata readme file in test_data/readmes
  2. Add placeholders TEST_TODAYS_DATE and PROJECT_ID_{i} to the newly generated readme file
  3. Update test_create_portal_metadata to use assertProjectReadmeContent and confirm the correctness of the portal metadata readme file
@nozomione nozomione added the API label Aug 29, 2024
@nozomione nozomione self-assigned this Aug 29, 2024
@nozomione nozomione changed the title Update test to use assertProjectReadmeContent for create_portal_metadata management command Update create_portal_metadata management command test to use assertProjectReadmeContent Aug 29, 2024
@nozomione nozomione changed the title Update create_portal_metadata management command test to use assertProjectReadmeContent Update test_create_portal_metadata to use assertProjectReadmeContent Aug 29, 2024
@nozomione nozomione changed the title Update test_create_portal_metadata to use assertProjectReadmeContent Update test_create_portal_metadata to use assertProjectReadmeContent Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant