-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pcr0tool): Add verb pcrread
#364
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,79 @@ | ||
package pcrread | ||
|
||
import ( | ||
"context" | ||
"flag" | ||
"fmt" | ||
"log" | ||
"os" | ||
"strconv" | ||
"strings" | ||
|
||
"github.com/google/go-tpm/tpm2" | ||
|
||
"github.com/9elements/converged-security-suite/v2/pkg/bootflow/subsystems/trustchains/tpm/pcr" | ||
"github.com/9elements/converged-security-suite/v2/pkg/tpm" | ||
) | ||
|
||
func assertNoError(err error) { | ||
if err != nil { | ||
log.Fatal(err) | ||
} | ||
} | ||
|
||
func usageAndExit() { | ||
flag.Usage() | ||
os.Exit(2) | ||
} | ||
|
||
// Command is the implementation of `commands.Command`. | ||
type Command struct { | ||
hashAlgo *string | ||
} | ||
|
||
// Usage prints the syntax of arguments for this command | ||
func (cmd Command) Usage() string { | ||
return "<PCR index>" | ||
} | ||
|
||
// Description explains what this verb commands to do | ||
func (cmd Command) Description() string { | ||
return "read the PCR value" | ||
} | ||
|
||
// SetupFlagSet is called to allow the command implementation | ||
// to setup which option flags it has. | ||
func (cmd *Command) SetupFlagSet(flag *flag.FlagSet) { | ||
cmd.hashAlgo = flag.String("hash-algo", tpm2.AlgSHA1.String(), "") | ||
} | ||
|
||
// Execute is the main function here. It is responsible to | ||
// start the execution of the command. | ||
// | ||
// `args` are the arguments left unused by verb itself and options. | ||
func (cmd Command) Execute(ctx context.Context, args []string) { | ||
if len(args) < 1 { | ||
_, _ = fmt.Fprintf(flag.CommandLine.Output(), "error: no PCR index is specified\n") | ||
usageAndExit() | ||
} | ||
if len(args) > 1 { | ||
_, _ = fmt.Fprintf(flag.CommandLine.Output(), "error: too many parameters\n") | ||
usageAndExit() | ||
} | ||
pcrIndexString := args[0] | ||
pcrIndex, err := strconv.ParseUint(pcrIndexString, 10, 64) | ||
assertNoError(err) | ||
|
||
hashAlgo := tpm2.AlgUnknown | ||
for _, alg := range []tpm2.Algorithm{tpm2.AlgSHA1, tpm2.AlgSHA256} { | ||
if strings.EqualFold(*cmd.hashAlgo, alg.String()) { | ||
hashAlgo = alg | ||
} | ||
} | ||
if hashAlgo == tpm2.AlgUnknown { | ||
panic(fmt.Errorf("algo '%s' is unknown", *cmd.hashAlgo)) | ||
} | ||
pcr, err := tpm.ReadPCRFromTPM(pcr.ID(pcrIndex), hashAlgo) | ||
assertNoError(err) | ||
fmt.Printf("%X\n", pcr) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really want a
panic
here? Seems like we'd want just an error.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the CLI tool is executed with invalid arguments, then the execution should be interrupted. And this code is responsible for the CLI experience. Replaced with
log.Fatal
to be consistent with the rest of the code. Let me know if you'd like another solution.