feat(pcr0tool): Add verb pcrread
#364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the status here @rihter007 @trynity @u1f35c ? |
trynity
approved these changes
Jan 29, 2024
| } | ||
| } | ||
| if hashAlgo == tpm2.AlgUnknown { | ||
| panic(fmt.Errorf("algo '%s' is unknown", *cmd.hashAlgo)) |
There was a problem hiding this comment.
Do we really want a panic here? Seems like we'd want just an error.
There was a problem hiding this comment.
If the CLI tool is executed with invalid arguments, then the execution should be interrupted. And this code is responsible for the CLI experience. Replaced with log.Fatal to be consistent with the rest of the code. Let me know if you'd like another solution.
* List commands alphabetically. * Use log.Fatalf instead of panic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a simple tool to read a PCR value from TPM (without using
tpm2-tools).Feel free to reject this PR. I only added this PR for a single one-time investigation to differentiate if the bug is in tpm2-tools or with TPM module (or its kernel driver) itself.