Add MastForest::advice_map for the data required in the advice provider before execution
#1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenhat
force-pushed
the
greenhat/i1547-mastforest-add-advicemap
branch
from
f1fd68b
to
a36a9af
Compare
Since the behavior if the key is already present is to replace the value with the new one there is no other error that can possibly arise in this method.
greenhat
force-pushed
the
greenhat/i1547-mastforest-add-advicemap
branch
from
d890a6a
to
fe7a7da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements VM-facing part of #1547 and adds advice data to the
MastForestthat is required to be in the advice provider when theMastForestexecuted.TODO:
AdviceMaptype tocore;MastForest::advice_map;MastForest::advice_mapbefore executing theMastForest;MastForest::advice_mapwhen merging MAST forests (join with otherAdviceMaps);MastForestshould handle theAdviceMapas well.TODO(compiler side):
rodatainMastForest::advice_mapand not store it separately in thePackage.