Refactor Host and AdviceProvider
#1572
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plafer
force-pushed
the
plafer-refactor-process-state
branch
from
d27cb3d
to
c21c8ba
Compare
plafer
force-pushed
the
plafer-1457-refactor-host-advice-provider
branch
from
164b6c3
to
8af6358
Compare
greenhat
reviewed
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #1571
A round of refactoring to make the PR that addresses #1457 more self contained. The subsequent PR will
Operation::Emit { event_source: u32, event_id: u32 }as described hereEmitwith anevent_source = 0AdviceInjector