Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add service package and start splitting HTTP handling #1427

refactor(service): make `Info` fields private

68971d0
Select commit
Loading
Failed to load commit list.
Closed

refactor: add service package and start splitting HTTP handling #1427

refactor(service): make `Info` fields private
68971d0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 30, 2024 in 1s

No report found to compare against

View this Pull Request on Codecov

No report found to compare against

Details

Codecov Report

Attention: Patch coverage is 90.15385% with 32 lines in your changes missing coverage. Please review.

Please upload report for BASE (refactor/services-dependencies@380906d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
server/server.go 80.00% 8 Missing and 4 partials ⚠️
config/config.go 0.00% 8 Missing ⚠️
server/doh.go 91.22% 3 Missing and 2 partials ⚠️
metrics/metrics.go 0.00% 4 Missing ⚠️
cmd/serve.go 0.00% 1 Missing and 1 partial ⚠️
metrics/metrics_event_publisher.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##             refactor/services-dependencies    #1427   +/-   ##
=================================================================
  Coverage                                  ?   91.24%           
=================================================================
  Files                                     ?       91           
  Lines                                     ?     5424           
  Branches                                  ?        0           
=================================================================
  Hits                                      ?     4949           
  Misses                                    ?      390           
  Partials                                  ?       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.