Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add service package and start splitting HTTP handling #1427

Closed
wants to merge 7 commits into from
Closed

refactor: add service package and start splitting HTTP handling #1427

wants to merge 7 commits into from

Commits on Aug 30, 2024

  1. refactor: move util package tests to dedicated package 

    Allow helpertest to use util since only the tests need helpertests, we
can use util from there without creating a circular dependency.
    @ThinkChaos
    ThinkChaos committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    9da89c3 View commit details
    Browse the repository at this point in the history

  2. refactor: add service package to prepare for split HTTP handling 

    Package service exposes types to abstract services from the networking.

The idea is that we build a set of services and a set of network
endpoints (Listener). The services are then assigned to endpoints based
on the address(es) they were configured for.

Actual service to endpoint binding is not handled by the abstractions in
this package as it is protocol specific.
The general pattern is to make a "server" that wraps a service, and can
then be started on an endpoint using a `Serve` method,
similar to `http.Server`.

To support exposing multiple compatible services on a single endpoint
(example: DoH + metrics on a single port),
services can implement `Merger`.
    @ThinkChaos
    ThinkChaos committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    ea921a6 View commit details
    Browse the repository at this point in the history

  3. refactor: switch DoH to Service pattern

    @ThinkChaos
    ThinkChaos committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    5571e19 View commit details
    Browse the repository at this point in the history

  4. refactor: switch metrics to Service pattern

    @ThinkChaos
    ThinkChaos committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    a4e3c49 View commit details
    Browse the repository at this point in the history

  5. refactor: switch HTTP API to Service pattern

    @ThinkChaos
    ThinkChaos committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    3a1f5ca View commit details
    Browse the repository at this point in the history

  6. refactor: add service.SimpleHTTP to reduce required boilerplate

    @ThinkChaos
    ThinkChaos committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    5e8708e View commit details
    Browse the repository at this point in the history

  7. refactor(service): make Info fields private

    @ThinkChaos
    ThinkChaos committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    68971d0 View commit details
    Browse the repository at this point in the history