Extracted compatibility module to work without AioModel subclassing #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudyryk
force-pushed
the
refactoring/manager-compat
branch
from
785b246
to
a0138ba
Compare
This was referenced May 4, 2024
Closed
kalombos
requested changes
May 5, 2024
rudyryk
force-pushed
the
refactoring/manager-compat
branch
from
a0138ba
to
06386fa
Compare
kalombos
reviewed
May 9, 2024
kalombos
requested changes
May 9, 2024
rudyryk
force-pushed
the
refactoring/manager-compat
branch
from
bd04d1c
to
e12b10c
Compare
kalombos
reviewed
May 9, 2024
kalombos
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted module
peewee_async_compatwhich containsManagerand other older interfaces to make cleaner separation from newer implementation based onAioModeletc._patch_query_with_compat_methods()AioModelsubclassing_swap_database(), it was an internal purely experimental feature