-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split code by files #223
Comments
I suggest to stick with a single Not because I dislike modules but because peewee itself is a single peewee.py and it contains much-much more complexity. Being one-file ORM is a spirit of the initial project, and I'd love to follow that. But what we could to for cleanups it to extract legacy / deprecated modules into |
|
Yeah I know about single peewee.py and i remember how 6-8 years ago my computer slowed down when i opened the file :)This happened because the IDE did not have enough resources to parse a file of 10 thousand lines. And it may lead to cyclic imports and this may lead to import hell :) Also i am worried about that we put all our files(peewee_async, *_compat, *_ext) in the root of the python package directory. It seems no big deal at the moment but you know the Murphy's law... :) Some day somebody will create local peewee_compat file and lose couple of hours in debugging. So i think encapsulate our package at first is not a bad idea :) Splitting also could be helpful for typing #224 to make the process iterative. All i am trying to say the spirit of peewee is not for free we should pay for it(our time). Do we really need this? |
Fair point :) OK, let's split it then. |
Нужно вынести части кода в отдельные файлы. Удобнее делать это в несколько итераций, т.к. на данный момент при установке пакет в корень директории с модулями копируются файлы peewee_async.py peewee_asyncext.py Нужно завести директорию peewee-async и перенести в неё peewee_async.py сохранив импорты, также смотри #222
The text was updated successfully, but these errors were encountered: