Fixed: Incorrect Handling of Qualifiers in ConstantExpressionHelper #824
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
There is an issue in the
ExpressionPromoter
class where the qualifier in the numeric literal expressions is not correctly handled, leading to incorrect type promotions. This is due to the way qualifiers are stored and retrieved from theConstantExpressionHelper
.Steps to Reproduce:
ParsingConfig
.NumberParser
to parse a numeric literal with a qualifier.ExpressionPromoter
.Example 1:
Example 2:
Expected Behavior:
The
Promote
method should correctly handle the qualifier and convert the numeric literal to the specified target type.Actual Behavior:
The promotion fails, and the conversion does not occur as expected due to the incorrect handling of the qualifier in the
ConstantExpressionHelper
.Additional Information:
This issue affects applications that rely on dynamic LINQ queries where numeric-type promotions with qualifiers are necessary.
Proposed Solution:
Ensure that the
CreateLiteral
inConstantExpressionHelper
correctly handles qualifiers without the prefix when creating and retrieving constant expressions.