Applied case sensitivity settings to KeywordsHelper #735
Conversation
|
@StefH, I am unable to find the right place to add test cases for this, could you guide me? |
StefH
changed the title
|
Added test case for Keywords Helper
|
@StefH Addressed your comment and added test cases, please review again |
|
@StefH when can we merge/release this PR? |
I'll take a look. |
|
because of PR #755, this PR needs to be updated.... |
|
@StefH I have updated the PR. Although looking at your PR, you seem to have fixed case issue with custom types. This PR will only help people make Context keywords case sensitive via config . I will leave it upto you if you want to complete this PR. |
|
My original goal of this PR was to make predefined and custom types case sensitive :) |
test/System.Linq.Dynamic.Core.Tests/Parser/KeywordsHelperTests.cs
Outdated
Show resolved
Hide resolved
test/System.Linq.Dynamic.Core.Tests/Parser/KeywordsHelperTests.cs
Outdated
Show resolved
Hide resolved
test/System.Linq.Dynamic.Core.Tests/Parser/KeywordsHelperTests.cs
Outdated
Show resolved
Hide resolved
|
@abbasc52 |
|
@StefH fixed the review comments |
| public void TryGetValue_WithCaseSensitiveSettings_ReturnsResultAsExpected(string name, bool areKeywordsCaseSensitive,bool expected) | ||
| { | ||
| // Arrange | ||
| var keywordsHelper = this.CreateKeywordsHelper(new ParsingConfig { AreKeywordsCaseSensitive = areKeywordsCaseSensitive }); |
| [InlineData("TestClass", true, true)] | ||
| [InlineData("testClass", true, false)] | ||
| [InlineData("nonExisting", true ,false)] | ||
| public void TryGetValue_WithCaseSensitiveSettings_ReturnsResultAsExpected(string name, bool areKeywordsCaseSensitive,bool expected) |
There was a problem hiding this comment.
Do a format file to align the source code (adding some spaces)
|
@abbasc52 |
1 similar comment
|
@abbasc52 |
|
Hello @abbasc52, can you please take a look at my review comments? |
2 similar comments
|
Hello @abbasc52, can you please take a look at my review comments? |
|
Hello @abbasc52, can you please take a look at my review comments? |
|
Extended case sensitivity settings to KeywordHelper