Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Sort direction #672

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Fix: Sort direction #672

merged 1 commit into from
Nov 18, 2024

Conversation

sevonj
Copy link
Contributor

@sevonj sevonj commented Nov 18, 2024

Closes #669

Might also be a good idea to replace "reversed" terminology with ascending/descending in the code, for extra clarity.

@zyrouge zyrouge self-requested a review November 18, 2024 12:28
@zyrouge zyrouge merged commit ea9bbd6 into zyrouge:main Nov 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Ascending/descending sorting is opposite to the one expected
2 participants