Add Source Link to the sources #2036
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Sort the uploaded files alphabetically
Change Source to hyperlink to local pdf with corresponding page
add a setting named USE_HYPERLINKS_FOR_SOURCES
|
|
jaluma
requested changes
Aug 6, 2024
| @@ -55,9 +55,11 @@ class Source(BaseModel): | |||
| file: str | |||
| page: str | |||
| text: str | |||
| pdf_prefix: str = "C:/UsedFilesFolder/" | |||
There was a problem hiding this comment.
you cannot assume that. You will need to store files in a folder in addition to current process
|
|
||
| def to_hyperlink(self) -> str: | ||
| encoded_file = self.file.replace(" ", "%20") | ||
| file_path = f"{self.pdf_prefix}{encoded_file}#page={self.page}" |
There was a problem hiding this comment.
#page will only work when it's a doc and it's indexable (e.g. pdf)
| sources_text | ||
| + f"{index}. {source.file} (page {source.page}) \n\n" | ||
| ) | ||
| if settings().USE_HYPERLINKS_FOR_SOURCES: |
There was a problem hiding this comment.
there is a ui setting object. The best idea is create a new filed in UI settings and create a boolean property
There was a problem hiding this comment.
In general, you will need to do more than you might expect. Storing files in the local folder may not be trivial. If anything, please update the PR, ping me and we'll check it out :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change does two things. The files to be used on the left-hand side are sorted alphabetically. This makes it easier to find the individual files you want to work with.
Furthermore, the variable USE_HYPERLINKS_FOR_SOURCES = TRUE can be used to refer to local sources via hyperlink.
BUG: Hyperlink is generated but cannot be clicked.
Type of Change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist:
make check; make testto ensure mypy and tests pass