Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Milvus vector db Integration #1996

Merged
merged 11 commits into from
Jul 18, 2024
Merged

Milvus vector db Integration #1996

merged 11 commits into from
Jul 18, 2024

Conversation

Jacksonxhx
Copy link
Contributor

integrated Milvus vector db into private GPT

jaluma
jaluma requested changes Jul 17, 2024
View reviewed changes
fern/docs/pages/manual/vectordb.mdx Show resolved Hide resolved
private_gpt/components/vector_store/vector_store_component.py Show resolved Hide resolved
settings.yaml Outdated Show resolved Hide resolved
jaluma
jaluma requested changes Jul 17, 2024
View reviewed changes
private_gpt/components/vector_store/vector_store_component.py Outdated Show resolved Hide resolved
private_gpt/settings/settings.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Published docs preview URL: https://privategpt-preview-d278a1da-a5f1-46e1-a244-50799515f90c.docs.buildwithfern.com

@Jacksonxhx
Copy link
Contributor Author

Changes are all updated, thanks for the patient and time to review!

@github-actions GitHub Actions
Copy link
Contributor

Published docs preview URL: https://privategpt-preview-9f5610d7-c2b8-46e7-b9f7-3963c8000a26.docs.buildwithfern.com

@github-actions GitHub Actions
Copy link
Contributor

Published docs preview URL: https://privategpt-preview-f6faec69-8f76-43a9-91ce-30450d51ae73.docs.buildwithfern.com

jaluma
jaluma previously approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@jaluma jaluma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

@github-actions GitHub Actions
Copy link
Contributor

Published docs preview URL: https://privategpt-preview-a6788a93-8e93-44d6-8e0d-db5a8c996ef0.docs.buildwithfern.com

@Jacksonxhx
Copy link
Contributor Author

All conflicts and minor format issues solved. Thanks for the patient and time to review, will follow up the future changes!

@zc277584121
Copy link

LGTM, i think it is ready for merging :)

jaluma
jaluma approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@jaluma jaluma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imartinez imartinez merged commit 43cc31f into zylon-ai:main Jul 18, 2024
8 checks passed
@github-actions github-actions bot mentioned this pull request Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zc277584121 zc277584121 zc277584121 left review comments

@jaluma jaluma jaluma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jacksonxhx @zc277584121 @jaluma @imartinez