Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated to Python 3 and fixed a bug in xgb defs #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kdubovikov
Copy link

Hi, I have migrated the codebase to Python 3 and fixed a bug in defs/xgb.py. Hope this will be useful

@zygmuntz
Copy link
Owner

Thanks, but it won't work with Python 2 now, will it?

@kdubovikov
Copy link
Author

kdubovikov commented Jun 25, 2017

Yes, you are right. I will manage this with from __future__ import print_function and update the PR. Then it will work with Python 2 and 3 simultaneously

UPDATE please see new commit, you may check if it works with Python 2 now

@zygmuntz
Copy link
Owner

zygmuntz commented Jun 28, 2017

You haven't updated all the prints in defs/* and defs_regression/*, though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants