Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Program and Assembler non-final #146

Merged
merged 1 commit into from
Oct 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions zasm/include/zasm/program/program.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ namespace zasm

class Observer;

class Program final
class Program
{
std::unique_ptr<detail::ProgramState> _state;

Expand All @@ -39,11 +39,11 @@ namespace zasm
/// Constructs an empty program with the specified machine mode.
/// </summary>
/// <param name="mode">Machine Mode</param>
Program(MachineMode mode);
explicit Program(MachineMode mode);

Program(const Program&) = delete;
Program(Program&& other) noexcept;
~Program();
virtual ~Program();

Program& operator=(const Program&) = delete;
Program& operator=(Program&& other) noexcept;
Expand Down
6 changes: 3 additions & 3 deletions zasm/include/zasm/x86/assembler.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@ namespace zasm

namespace zasm::x86
{
class Assembler final : public Emitter<Assembler>, public Observer
class Assembler : public Emitter<Assembler>, public Observer
{
Program& _program;
Node* _cursor{};
InstrAttribs _attribState{};

public:
Assembler(Program& _program);
~Assembler();
explicit Assembler(Program& _program);
virtual ~Assembler();

/// <summary>
/// Sets the node at where the next node will be inserted after.
Expand Down
Loading