-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'enter' bug #41
Open
ebergama
wants to merge
84
commits into
zuriby:master
Choose a base branch
from
jeresig:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
'enter' bug #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de stripped and bugs fixed.
the short code
Password and HTML5 input types
Might be useful, when you want to pass some other data to your handler
Added three special keys: ; ' \
Updated README with on()/off()
Passing other arguments to binding
Update - foreach for bind!
it is triggered by IE when pressing Ctrl+Return
Updated the link to Tzury's hotkeys instead of a 404.
add keyCode 10 for return
…to be on the global scope, updated linting to catch these issues.
Fix keypress on special keys and keydown/keyup on characters
restore keyup/keydown for character keys
minor edit
Make this module compatible with Browserify
I'm not sure about the Licence or different things, but since the issues are not enabled for this project I just created a PR with the simplest one.. it is super useful and it looks like the original project is a bit dead..
Added bower.json file
rpocklin
force-pushed
the
master
branch
3 times, most recently
from
September 30, 2014 12:14
90e8908
to
734acfc
Compare
should also escape text-accepting inputs like search fields unless explicitly bound
Adding `input` type to be unbound unless explicitly specified.
Thanks to @cagataygurturk for pointing this out.
Fixing incorrect url for original plugin project in code.
Fixed url markdown formatting
Update README.md
Fixed version number from 0.8 to 0.2.0
Fixed version number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In specialKeys declaration (line 23) the key 'return' is duplicate, and also its mapping to de keycode 13 that corresponds to enter.