Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy-annotations.md: Edit commit message instructions #689

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

mypy-annotations.md: Edit commit message instructions #689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tasks/2017/mypy-annotations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,11 @@ Let *bot* be a bot listed in the task that brought you here.
file, as well as any other python files in the directory
`python-zulip-api/zulip_bots/zulip_bots/bots/<bot>`.

* Add all the files you've just annotated to the `force_include` list in
* Add all the files (not folders) you've just annotated to the `force_include` list in
`tools/run-mypy`. Test your local changes by running
`tools/test-static-analysis` and `tools/test-bots`.

* Commit your changes with a commit message titled `mypy: Add annotations for <bot>.`
* Commit your changes with a commit message titled `bots/<bot>: Use Python 3 type mypy annotations.`

After you've converted the annotations for all the listed bots, submit
a pull request with title `mypy: Add annotations for bots.` to the
Expand Down