Allow fuzzy search to match after cursor position #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunaku
reviewed
Sep 22, 2018
| @@ -246,7 +246,11 @@ _history-substring-search-begin() { | |||
| # Escape and join query parts with wildcard character '*' as seperator | |||
| # `(j:CHAR:)` join array to string with CHAR as seperator | |||
| # | |||
| local search_pattern="*${(j:*:)_history_substring_search_query_parts[@]//(#m)[\][()|\\*?#<>~^]/\\$MATCH}*" | |||
| if [[ -z $HISTORY_SUBSTRING_SEARCH_FUZZY_AFTER_CURSOR ]]; then | |||
| local search_pattern="${(j:*:)_history_substring_search_query_parts[@]//(#m)[\][()|\\*?#<>~^]/\\$MATCH}*" | |||
There was a problem hiding this comment.
Could you factor out the duplication? 😱 It's safe to always execute this line. 🤓 Next, you can conditionally prefix the * if this fuzzy-after-cursor option is not enabled.
dominik-ba
reviewed
Mar 23, 2020
Comment on lines
+249
to
+253
| if [[ -z $HISTORY_SUBSTRING_SEARCH_FUZZY_AFTER_CURSOR ]]; then | ||
| local search_pattern="${(j:*:)_history_substring_search_query_parts[@]//(#m)[\][()|\\*?#<>~^]/\\$MATCH}*" | ||
| else | ||
| local search_pattern="*${(j:*:)_history_substring_search_query_parts[@]//(#m)[\][()|\\*?#<>~^]/\\$MATCH}*" | ||
| fi |
There was a problem hiding this comment.
Suggested change
| if [[ -z $HISTORY_SUBSTRING_SEARCH_FUZZY_AFTER_CURSOR ]]; then | |
| local search_pattern="${(j:*:)_history_substring_search_query_parts[@]//(#m)[\][()|\\*?#<>~^]/\\$MATCH}*" | |
| else | |
| local search_pattern="*${(j:*:)_history_substring_search_query_parts[@]//(#m)[\][()|\\*?#<>~^]/\\$MATCH}*" | |
| fi | |
| local search_pattern="*${(j:*:)_history_substring_search_query_parts[@]//(#m)[\][()|\\*?#<>~^]/\\$MATCH}*" | |
| if [[ -z $HISTORY_SUBSTRING_SEARCH_FUZZY_AFTER_CURSOR ]]; then | |
| local search_pattern="${(j:*:)_history_substring_search_query_parts[@]//(#m)[\][()|\\*?#<>~^]/\\$MATCH}*" | |
| fi |
I guess this would be the wanted behavior then?
|
Any update on this? |
|
Would also be interested in seeing this merged. |
This was referenced May 20, 2021
|
Related PRs have been merged as of commit 4abed97. Please set the following configuration variable to enable this feature: HISTORY_SUBSTRING_SEARCH_PREFIXED=1Does this solve the problem this PR was meant to address? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.