Fix yank-pop and add test for cursor positioning #794
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the request cancelling logic from closing an unrelated fd that happens to reuse the same number.
The testing docker image has been split up. Instead of having one image with all supported versions of zsh installed, we now have a separate image for each supported zsh version. We use GitHub Action matrices to run jobs in parallel for all of the supported versions. We no longer need to publish images to Docker Hub. The images are just built by CI (or developers) as needed from the Dockerfile in the repo.
Cherry-picked from PR zsh-users#706 and updates made to src/config.zsh. Fixes issues zsh-users#678
Ensure that we're using the builtin exec
Always reset file descriptor after consuming it
We don't have any particular reason to unset. Clearing should be good enough, and avoid any errors using unset parameters. Cherry-picked from PR zsh-users#634
|
Oops, this was supposed to be for develop, rather than master :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on suggestion in PR #551 that notes a problem with yank-pop cursor positioning.
Fixed by moving
yankto:ZSH_AUTOSUGGEST_ZLE_YANKBEFORE_WIDGETSinstead of:
ZSH_AUTOSUGGEST_ZLE_YANK_WIDGETSAlso confirmed that this works to close #363 once merged in.