Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the dynlink stub generator to include the stub version #743

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Update the dynlink stub generator to include the stub version #743

merged 2 commits into from
Jan 28, 2025

Conversation

ifakhrutdinov
Copy link
Contributor

Proposed changes

This PR changes the generator tool to include the stub version as an EQU. This can be useful for build time verification if a user wants to ensure that the stub version matches the code in zss/zowe-common-c.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • Relevant update to CHANGELOG.md
  • My changes generate no new warnings

Testing

Use the stub generator tool with h/zis/zisstubs.h to generate the HLASM stub and verify that it contains ZISSTUBV which is equal to ZIS_STUBS_VERSION in h/zis/zisstubs.h.

@ifakhrutdinov
Update the dynlink stub generator to include the stub version
672ba1b 
This commits changes the generator tool to include the stub version
as an EQU. This can be useful for build time verification if a
user wants to ensure that the stub version matches the code in
zss/zowe-common-c.

Signed-off-by: Irek Fakhrutdinov <[email protected]>
@ifakhrutdinov ifakhrutdinov force-pushed the feature/stub-version-in-asm branch from a56baee to 672ba1b Compare January 10, 2025 07:33
@ifakhrutdinov ifakhrutdinov marked this pull request as ready for review January 10, 2025 07:33
@ifakhrutdinov ifakhrutdinov requested a review from JoeNemo January 10, 2025 07:33
@ifakhrutdinov ifakhrutdinov self-assigned this Jan 10, 2025
@ifakhrutdinov ifakhrutdinov added the enhancement New feature or request label Jan 10, 2025
JoeNemo
JoeNemo approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@JoeNemo JoeNemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@JoeNemo JoeNemo merged commit d3408f4 into v3.x/staging Jan 28, 2025
5 checks passed
@ifakhrutdinov ifakhrutdinov deleted the feature/stub-version-in-asm branch January 28, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeNemo JoeNemo JoeNemo approved these changes

Assignees

@ifakhrutdinov ifakhrutdinov

Labels
enhancement New feature or request
Projects
zOS Squad Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ifakhrutdinov @JoeNemo