Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure CEE3ERP is invoked in LE 31-bit XPLINK (Zowe v2) #503

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

ifakhrutdinov
Copy link
Contributor

@ifakhrutdinov ifakhrutdinov commented Nov 29, 2024

Proposed changes

When an ABEND occurs and there is a user-defined ESTAEX in an LE application, the language environment must be notified
via a call to CEE3ERP; that way LE has a chance to handle things like hitting a stack guard page. If we don't call
CEE3ERP, things can go terribly wrong.

At some point, the ZSS 31-bit build was changed to use XPLINK and the CEE3ERP call in the recovery facility was
erroneously limited to non-XPLINK 31-bit LE environments.

This PR changes the code to call the CEE3ERP routine in XPLINK 31-bit LE applications.

This PR addresses issue:

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • Relevant update to CHANGELOG.md
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

Regression testing of ZSS/ the config manager is needed.

When an ABEND occurs and there is a user-defined ESTAEX in
an LE application, the language environment must be notified
via a call to CEE3ERP; that way LE has a chance to handle
things like hitting a stack guard page. If we don't call
CEE3ERP, things can go terribly wrong.

At some point, the ZSS 31-bit build was changed to use
XPLINK and the CEE3ERP call in the recovery facility was
erroneously limited to non-XPLINK 31-bit LE environments.

This commit changes the code to call the CEE3ERP routine
in XPLINK 31-bit LE applications.

Fixes:
* zowe/zss#600
* zowe/zss#736

Signed-off-by: Irek Fakhrutdinov <[email protected]>
@ifakhrutdinov ifakhrutdinov force-pushed the bugfix/CEE3ERP-LE31-XPLINK branch from ff9021a to 639627b Compare November 29, 2024 12:58
@ifakhrutdinov ifakhrutdinov self-assigned this Nov 29, 2024
@ifakhrutdinov ifakhrutdinov added the bug Something isn't working label Nov 29, 2024
@ifakhrutdinov ifakhrutdinov marked this pull request as ready for review November 29, 2024 13:00
@ifakhrutdinov ifakhrutdinov changed the title Make sure CEE3ERP is invoked in LE 31-bit XPLINK Make sure CEE3ERP is invoked in LE 31-bit XPLINK (Zowe v2) Nov 29, 2024
Copy link
Contributor

@JoeNemo JoeNemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@JoeNemo JoeNemo merged commit 811e968 into v2.x/staging Dec 4, 2024
9 checks passed
@ifakhrutdinov ifakhrutdinov deleted the bugfix/CEE3ERP-LE31-XPLINK branch December 12, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants