-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy Data set bug + DeferredPromise format fix #2413
Open
pujal0909
wants to merge
16
commits into
master
Choose a base branch
from
copy-ds-bug
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
packages/cli/__tests__/zosfiles/__unit__/copy/ds/Ds.handler.unit.test.ts
Fixed
Show fixed
Hide fixed
packages/cli/__tests__/zosfiles/__unit__/copy/ds/Ds.handler.unit.test.ts
Fixed
Show fixed
Hide fixed
packages/cli/__tests__/zosfiles/__unit__/copy/ds/Ds.handler.unit.test.ts
Fixed
Show fixed
Hide fixed
Signed-off-by: Pujal <[email protected]>
pujal0909
force-pushed
the
copy-ds-bug
branch
from
January 16, 2025 18:13
f436109
to
484775d
Compare
Signed-off-by: Pujal <[email protected]>
pujal0909
force-pushed
the
copy-ds-bug
branch
from
January 16, 2025 18:17
563565c
to
af98302
Compare
…AM.ams.temp Signed-off-by: Pujal Gandhi <[email protected]>
…AM.ams.temp Signed-off-by: Pujal Gandhi <[email protected]>
Signed-off-by: Pujal <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2413 +/- ##
==========================================
+ Coverage 91.33% 91.34% +0.01%
==========================================
Files 639 639
Lines 18248 18258 +10
Branches 3907 3947 +40
==========================================
+ Hits 16666 16677 +11
+ Misses 1580 1579 -1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Pujal <[email protected]>
pujal0909
force-pushed
the
copy-ds-bug
branch
from
January 16, 2025 20:25
77b74c5
to
37c02a5
Compare
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
pujal0909
changed the title
Copy Data set bug
Copy Data set bug + DeferredPromise format fix
Jan 17, 2025
Signed-off-by: Pujal <[email protected]>
📅 Suggested merge-by date: 1/31/2025 |
pujal0909
requested review from
gejohnston,
zFernand0,
awharn,
traeok,
anaxceron,
ATorrise,
adam-wolfe,
t1m0thyj and
jace-roell
January 17, 2025 16:40
gejohnston
requested changes
Jan 17, 2025
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
#2369
Added a new --safe-replace (--safe-rep) option to the copy command that prompts users to confirm whether they want to overwrite the contents of the target data set.
Also, made a small format fix on the DeferredPromise.ts and DeferredPromise.unit.test files.
How to Test
Use the --safe-replace flag with the copy command. A prompt will appear, where you can respond with "y/N".
zowe zos-files copy ds "data-set1" "data-set2" --safe-replace
Review Checklist
I certify that I have:
Additional Comments