Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Data set bug + DeferredPromise format fix #2413

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

pujal0909
Copy link
Contributor

@pujal0909 pujal0909 commented Jan 16, 2025

What It Does

#2369
Added a new --safe-replace (--safe-rep) option to the copy command that prompts users to confirm whether they want to overwrite the contents of the target data set.

Also, made a small format fix on the DeferredPromise.ts and DeferredPromise.unit.test files.

How to Test

Use the --safe-replace flag with the copy command. A prompt will appear, where you can respond with "y/N".
zowe zos-files copy ds "data-set1" "data-set2" --safe-replace

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.34%. Comparing base (f86212e) to head (98cdedb).

Files with missing lines Patch % Lines
packages/cli/src/zosfiles/copy/ds/Ds.handler.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2413      +/-   ##
==========================================
+ Coverage   91.33%   91.34%   +0.01%     
==========================================
  Files         639      639              
  Lines       18248    18258      +10     
  Branches     3907     3947      +40     
==========================================
+ Hits        16666    16677      +11     
+ Misses       1580     1579       -1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Pujal <[email protected]>
@pujal0909 pujal0909 changed the title Copy Data set bug Copy Data set bug + DeferredPromise format fix Jan 17, 2025
@pujal0909 pujal0909 marked this pull request as ready for review January 17, 2025 16:40
Copy link

📅 Suggested merge-by date: 1/31/2025

@pujal0909 pujal0909 requested a review from gejohnston January 17, 2025 19:35
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
66.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review/QA
Development

Successfully merging this pull request may close these issues.

2 participants