Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download record range flag #2411

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Download record range flag #2411

wants to merge 15 commits into from

Conversation

jace-roell
Copy link
Contributor

@jace-roell jace-roell commented Jan 15, 2025

What It Does
Added --recordRange to zowe jobs download output command

How to Test
Run command 'zowe jobs download o "" --rr "0-100"` against a valid job
Where 0 is the start of the spool and 100 is the end (zero-indexed)

Review Checklist
I certify that I have:

Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
jace-roell and others added 6 commits January 15, 2025 14:24
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
@jace-roell jace-roell marked this pull request as ready for review January 15, 2025 20:53
Copy link

📅 Suggested merge-by date: 1/29/2025

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.33%. Comparing base (97a3c68) to head (e81d36d).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2411    +/-   ##
========================================
  Coverage   91.33%   91.33%            
========================================
  Files         639      639            
  Lines       18248    18262    +14     
  Branches     3834     3949   +115     
========================================
+ Hits        16666    16680    +14     
  Misses       1580     1580            
  Partials        2        2            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Copy link
Member

@gejohnston gejohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested an extra confirmation for some of your tests.
Give some consideration to whether it would be helpful.
Either way I approve this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review/QA
Development

Successfully merging this pull request may close these issues.

3 participants