Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated for core cli #1981

Merged
merged 68 commits into from
Jan 30, 2024
Merged

Remove deprecated for core cli #1981

merged 68 commits into from
Jan 30, 2024

Conversation

ATorrise
Copy link
Contributor

@ATorrise ATorrise commented Nov 29, 2023

What It Does
Removes the following items marked as deprecated:

Review Checklist
I certify that I have:

Note

Changes were grouped into different commits to aid the review process.

Amber Torrise and others added 21 commits November 13, 2023 13:45
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
@ATorrise ATorrise linked an issue Nov 29, 2023 that may be closed by this pull request
11 tasks
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d6ad48) 91.00% compared to head (5617fe2) 91.07%.
Report is 2 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1981      +/-   ##
==========================================
+ Coverage   91.00%   91.07%   +0.06%     
==========================================
  Files         635      634       -1     
  Lines       18601    18540      -61     
  Branches     3866     3860       -6     
==========================================
- Hits        16928    16885      -43     
+ Misses       1672     1654      -18     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ATorrise ATorrise marked this pull request as ready for review November 30, 2023 16:33
Signed-off-by: Amber Torrise <[email protected]>
Amber Torrise and others added 4 commits January 23, 2024 15:58
@t1m0thyj t1m0thyj self-requested a review January 26, 2024 16:17
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

20 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ATorrise ATorrise added the release-current Indicates that there is no new functionality being delivered label Jan 30, 2024
@ATorrise ATorrise merged commit 3c5918e into next Jan 30, 2024
19 checks passed
@ATorrise ATorrise deleted the removeDeprecatedCore branch January 30, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-current Indicates that there is no new functionality being delivered
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v3: Remove deprecated constants, options, and methods
7 participants