Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ZOWE_EDITOR with ZOWE_OPT_EDITOR for consistency #1974

Merged
merged 8 commits into from
Nov 29, 2023

Conversation

t1m0thyj
Copy link
Member

What It Does

  • Replaces the ZOWE_EDITOR environment variable with ZOWE_OPT_EDITOR and --editor option on commands
  • Removes check for ZOWE_EDITOR environment variable in ProcessUtils.openInEditor

How to Test
Run the following commands with the --editor option:

  • zowe config edit
  • zowe config auto-init --edit
  • zowe config init --edit

Review Checklist
I certify that I have:

Additional Comments

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4d8999e) 91.03% compared to head (ba76246) 91.03%.
Report is 2 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1974      +/-   ##
==========================================
- Coverage   91.03%   91.03%   -0.01%     
==========================================
  Files         635      635              
  Lines       18613    18608       -5     
  Branches     3861     3859       -2     
==========================================
- Hits        16944    16939       -5     
  Misses       1668     1668              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Timothy Johnson <[email protected]>
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@t1m0thyj t1m0thyj dismissed ATorrise’s stale review November 29, 2023 14:15

fixed lint warnings

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @t1m0thyj

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing the changelog

@t1m0thyj t1m0thyj merged commit e117919 into next Nov 29, 2023
22 checks passed
@t1m0thyj t1m0thyj deleted the feat/enhance-editor-option branch November 29, 2023 15:58
@t1m0thyj t1m0thyj added the release-current Indicates that there is no new functionality being delivered label Nov 29, 2023
Copy link

Release succeeded for the next branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-current Indicates that there is no new functionality being delivered released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v3: Consistent --editor option across CLI commands that can open editor
6 participants