-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ZOWE_EDITOR with ZOWE_OPT_EDITOR for consistency #1974
Conversation
Signed-off-by: Timothy Johnson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #1974 +/- ##
==========================================
- Coverage 91.03% 91.03% -0.01%
==========================================
Files 635 635
Lines 18613 18608 -5
Branches 3861 3859 -2
==========================================
- Hits 16944 16939 -5
Misses 1668 1668
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Timothy Johnson <[email protected]>
3c40f03
to
68ee82c
Compare
packages/imperative/src/imperative/src/config/cmd/edit/edit.definition.ts
Show resolved
Hide resolved
packages/imperative/src/imperative/src/config/cmd/edit/edit.definition.ts
Show resolved
Hide resolved
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @t1m0thyj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for fixing the changelog
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
ZOWE_EDITOR
environment variable withZOWE_OPT_EDITOR
and--editor
option on commandsZOWE_EDITOR
environment variable inProcessUtils.openInEditor
How to Test
Run the following commands with the
--editor
option:zowe config edit
zowe config auto-init --edit
zowe config init --edit
Review Checklist
I certify that I have:
Additional Comments